CP2 #846
Merged
CP2 #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index and the groups were at the same level. The should be at different one, for instance if the index is Nat, and the group something else
-> Modify some notions in gradedCommutativity -> new lemme for the "good" -h^ -> proof
-> Because this case is so degenerated, things compute. This new proof is forgetting some of the computation to have proof that will rise better to non-degenerated case
-> changing gradedComm by gradedCom' to account the previuous change
-> There is a need of the special as on the left we need the CommRing to take A / < a, ..., b > and we nedd a ring on the right as H*(X) is not a CommRing but a gradedComm Ring
-> A cleaner way to deal with the cup product -> Finish all the structure except some cases of the cup-product -> Prove the retraction property
|
@mortberg done |
mortberg
requested changes
Sep 18, 2022
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
Co-authored-by: Anders Mörtberg <andersmortberg@gmail.com>
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aljungstrom @mortberg this now the one about CP2
The missing lemma https://github.com/agda/cubical/pull/846/files#diff-698ce42781a40deec28df98fa92612bbea8a1672b47c9cda870dd00d22ef2e8dR441