Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling back an equivalence relation along a function #876

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

MatthiasHu
Copy link
Contributor

This PR is a small contribution that shows that equivalence relations can be pulled back along functions.

@felixwellen felixwellen self-requested a review July 31, 2022 17:52
@felixwellen
Copy link
Collaborator

I don't get the name "on". Maybe it would be better to be more verbose?

@MatthiasHu
Copy link
Contributor Author

I took the name from Haskell: https://hackage.haskell.org/package/base-4.16.3.0/docs/Data-Function.html#v:on

But I understand that it is not optimal. Would it be an option to give the module a name (such as PulledBackRelation) so that one can write the following?

_~_ = ...

_~'_ = on fst _~_
  where open PulledBackRelation

@felixwellen
Copy link
Collaborator

Hm. So "on" means "along"?
If I read "on fst R" somewhere, I would have no idea what it is about. What about just renaming "on" to "pulledbackRel" or "relPullback" or something like this?

@MatthiasHu
Copy link
Contributor Author

Ok, I went with pulledbackRel.

Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me now.

@felixwellen felixwellen merged commit a40c403 into agda:master Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants