Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H*(Kleinbottle,Z/2) #928

Merged
merged 11 commits into from
Sep 19, 2022
Merged

H*(Kleinbottle,Z/2) #928

merged 11 commits into from
Sep 19, 2022

Conversation

aljungstrom
Copy link
Contributor

@aljungstrom aljungstrom commented Sep 12, 2022 •
edited
Loading

This PR contains

  • Def of cohomology rings with R-coeffs (pretty much a direct copy of the Z-case)
  • Cohomology ring of the Klein bottle in Z/2-coeffs.
  • For some reason I had cohomology groups of wedge sums on this branch too, so I threw them in as well.

@aljungstrom aljungstrom marked this pull request as ready for review September 13, 2022 00:48
@thomas-lamiaux
Copy link
Contributor

Shouldn't this def be in algebra ?
https://github.com/agda/cubical/pull/928/files#diff-2ac1bdc3baa3997bd843c09403b37cfa86fbb20580d09320cc88bbc58ad940e9R205

@mortberg
Copy link
Collaborator

Shouldn't this def be in algebra ? https://github.com/agda/cubical/pull/928/files#diff-2ac1bdc3baa3997bd843c09403b37cfa86fbb20580d09320cc88bbc58ad940e9R205

I can't see which proof you're referring to. Please comment on the actual line in the code instead

mortberg
mortberg approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after a quick skim through

@mortberg mortberg merged commit 7b725b4 into agda:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortberg mortberg mortberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aljungstrom @thomas-lamiaux @mortberg