Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced cohomology+Eilenberg-Steenrod axioms #955

Merged
merged 21 commits into from
Sep 16, 2023
Merged

Conversation

aljungstrom
Copy link
Contributor

This PR contains:

  1. Reduced cohomology with arbitrary group coefficients
  2. A proof that this theory satisfies the Eilenberg-Steenrod axioms

@aljungstrom aljungstrom mentioned this pull request Nov 28, 2022
@rwbarton
Copy link
Contributor

I think the definition of coHomTheory should also have fields Hmap_id and Hmap_const, right?
Perhaps you want to add them and their proofs for ordinary cohomology in this PR also?

@aljungstrom
Copy link
Contributor Author

I think the definition of coHomTheory should also have fields Hmap_id and Hmap_const, right? Perhaps you want to add them and their proofs for ordinary cohomology in this PR also?

Wups! Thanks for pointing this out. I'll fix it in a separate PR as soon as Anders merges this one (and the Gysin one since it depends on this one).

@felixwellen felixwellen self-assigned this Jul 10, 2023
@felixwellen
Copy link
Collaborator

Same here. It still checks on current master, if you change "--experimental-lossy-unification" to "--lossy-unification".

Copy link
Collaborator

@felixwellen felixwellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - I only have organisational comments and one fix.

Cubical/Cohomology/EilenbergMacLane/EilenbergSteenrod.agda Outdated Show resolved Hide resolved
Cubical/Cohomology/EilenbergMacLane/Base.agda Outdated Show resolved Hide resolved
Cubical/Cohomology/EilenbergMacLane/Base.agda Show resolved Hide resolved
Cubical/Cohomology/EilenbergMacLane/EilenbergSteenrod.agda Outdated Show resolved Hide resolved
@mortberg
Copy link
Collaborator

@aljungstrom Can you fix @felixwellen's comments and then we can merge?

We should not forget to add the missing fields that @rwbarton pointed out as well

@mortberg
Copy link
Collaborator

Merging this now.

@aljungstrom please make a new PR adding the two missing fields from coHomTheory (functoriality for Hmap) and necessary proofs for the cohomology theories we have

@mortberg mortberg merged commit 7d47cf3 into agda:master Sep 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants