-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smash products - symmetric monoidal structure #973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me modulo conflicts. Please fix then I'll merge
A question: could the precategory notions be used for the proofs of category stuff? Like prefunctor for functor, etc. Seems like there is some code duplication otherwise?
That works for a surprising amount of stuff. I think the 'right' way to do it is to prove what we can on the level of wild categories (which, I think, we don't have yet). That seems to have worked very well for coq-hott... I'm not suggesting any of that should be done now, just using the opportunity to point something out. |
@mortberg done. And yeah, I agree that a lot of the cat stuff should be done for precats (which we should probably rename to wild categories or something) first. In the future maybe... (I never work with the category part of the library, so I'm probably not the right person to change this) |
I can open an issue about it so that we don't forget. I'll merge this now |
This PR contains