Fork Stuff #79
Merged
Fork Stuff #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k, not really sure right now
jrddunbr
added
enhancement
in progress
playtest
Grissess
requested changes
Jan 17, 2019
There was a problem hiding this comment.
I'm happy to see a simplified Travis and the removal of a potentially-unintended secret, but I have no way of testing that--so I'm going to trust that all is well there :)
I'm listing this as requesting changes, but all of these points are arguable to varying degree. Feel free to compel me :)
jrddunbr
changed the title
|
@Grissess Take a look and tell me what you think. I did some small modifications to the version checker as well. I want to do some work with the analytics handler, but not in this merge. |
jrddunbr
removed
jrddunbr's touch
|
Alright, merging now. |
jrddunbr
added
ready
and removed
playtest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of information relevant to becoming a fork.
It's related to #77 and #64
I also want to fix Travis builds and do some refactoring to the contact information, status checks, analytics, etc.
This is not complete yet. I have a few things to add/fix/remove.
Sorry lashtear, I didn't dig through the commit history. I also have other contributors where I need to go back and look, this was just a brief first pass.