update dependencies #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agebrock
requested changes
Feb 13, 2017
| @@ -1,7 +1,7 @@ | |||
| var util = require('util'); | |||
| var defaults = require('lodash.defaults'); | |||
|
|
|||
| var ConfigError = function ConfigError(message, extra) { | |||
| var ConfigError = function (message, extra) { | |||
There was a problem hiding this comment.
Well it seems useless, but the function name was there for a reason ;)
Without the name the stucktrace does not label the error correctly.
There was a problem hiding this comment.
updating your eslint config requires this change
There was a problem hiding this comment.
Accepted since changing this rule requires a lot of changes.
agebrock
approved these changes
Feb 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.