Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding Environment support for Swagger localhost #116

Merged
merged 15 commits into from Oct 4, 2022

Conversation

computamike
Copy link
Collaborator

This PR fixes issue #114, allowing a developer to set up their local machine as part of the cloning process.

  • A .env.example file has been created. A developer could copy or rename this file to .env...
  • To make it consistent for all users, a NPM script has been set up - running npm run config will set up the .env file.
  • A new utility script has been added - config.ts, which performs the copy.

@ageddesi
Copy link
Owner

ageddesi commented Oct 3, 2022

Hi @computamike Thanks for this a bunch.
Please can you check the conflicts now that I have updated the target of the merge to v0.13.0

@computamike
Copy link
Collaborator Author

Hi @ageddesi - I have re-factored the configuration - it seems that the system now uses a JS class rather than a JSON object for configuration - which I actually think is better. I struggled a bit with trying to fix the code issues.

Have also seem some unused dependencies (in the swagger config) - but I guess that's a job for an other time.

@ageddesi ageddesi merged commit 8cf032b into ageddesi:v.0.13.0 Oct 4, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 4, 2022

@all-contributors add @computamike code

@allcontributors
Copy link
Contributor

@ageddesi

I've put up a pull request to add @computamike! 🎉

@ageddesi
Copy link
Owner

ageddesi commented Oct 4, 2022

Thanks @computamike for the amazing work, i will raise a ticket to remove the unused dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants