Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Mock] - Reviews #18

Closed
ageddesi opened this issue Aug 24, 2022 · 20 comments
Closed

[New Mock] - Reviews #18

ageddesi opened this issue Aug 24, 2022 · 20 comments
Labels
good first issue Good for newcomers hacktoberfest new mock New Mock For Consideration to the code base

Comments

@ageddesi
Copy link
Owner

ageddesi commented Aug 24, 2022

  1. Add more real worded reviews for a series of fake products. eg. A Gaming Sports drink, a new dvd player etc. (The more we do the merrier)
  2. Add fake worded reviews for a fake product using faker.lorem.sentence the same way we do in getRandomChat
@ageddesi ageddesi added the new mock New Mock For Consideration to the code base label Aug 25, 2022
@ageddesi
Copy link
Owner Author

Added two new endpoints in version 0.10.0

I have currently only added 5 fake reviews for a gaming sports drink. Need to make a few more categories and products so there is more options avaliable.

@Vishwak-Kiran
Copy link

Vishwak-Kiran commented Oct 1, 2022

How many products and its reviews do you need tho?

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 1, 2022

Hi @Vishwak-Kiran . As with our other endpoints we can allow the user to define the qty. Please see chat api endpoints as example.

Please branch from v.0.12.0

@Vishwak-Kiran Vishwak-Kiran removed their assignment Oct 1, 2022
@janetthieu
Copy link
Contributor

Hi @ageddesi, I'd like to contribute to this.

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 1, 2022

Hi @janetthieu it's all yours. :)

@lsheltonSTO
Copy link

Hi @ageddesi , do you need more contributions to this for Hacktoberfest?

@ageddesi
Copy link
Owner Author

Hi @lsheltonSTO absolutely.

@lsheltonSTO
Copy link

I'm still very much a rookie at this but I used to teach English so I can come up with a bunch of nonsense if you have something to assign to me @ageddesi !

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 11, 2022 via email

@lsheltonSTO
Copy link

Well, I also took 2 years of Latin in high school ;)

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 11, 2022 via email

@lsheltonSTO
Copy link

Are you looking for more fake reviews on the one product, or more products with their own fake reviews/categories/etc?

@ageddesi
Copy link
Owner Author

ageddesi commented Oct 11, 2022 via email

lsheltonSTO pushed a commit to lsheltonSTO/Mocked-API that referenced this issue Oct 12, 2022
ageddesi added a commit that referenced this issue Oct 12, 2022
Added more product reviews per issue #18
@ageddesi
Copy link
Owner Author

Thank you @lsheltonSTO for adding more products. I will leave this open, just in case anyone else wants to extend it

@jonathlan
Copy link
Contributor

Hello !

I'm new to hacktoberfest and should be able to help with this too.

Just to clarify, we need to add more reviews to this file modules/products/data/product-reviews.ts ?
Does the language matter?

Thanks !

@ageddesi
Copy link
Owner Author

Welcome @, yes more are welcome. We do jot have other languages yet. But want to open that up soon.

@jonathlan
Copy link
Contributor

Great, I will share a few in English then.
Awesome project, btw!

jonathlan added a commit to jonathlan/Mocked-API that referenced this issue Oct 13, 2022
ageddesi added a commit that referenced this issue Oct 13, 2022
@azulverdosa
Copy link
Contributor

Hi there @ageddesi ,

Another newby looking to help out! I see you're looking for new products, with fake reviews, added to this file: modules/products/data/product-reviews.ts . Anything else to mention?

Thanks!

@ageddesi
Copy link
Owner Author

Yerp feel free to add more. Either same products or new.

janetthieu added a commit to janetthieu/Mocked-API that referenced this issue Oct 13, 2022
ageddesi added a commit that referenced this issue Oct 14, 2022
feat: add mock product reviews (issue #18)
@ghost
Copy link

ghost commented May 19, 2023

  1. Add more real worded reviews for a series of fake products. eg. A Gaming Sports drink, a new dvd player etc. (The more we do the merrier)
  2. Add fake worded reviews for a fake product using faker.lorem.sentence the same way we do in getRandomChat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest new mock New Mock For Consideration to the code base
Projects
None yet
Development

No branches or pull requests

6 participants