Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 32: Add a pre-commit hook for lint checking and styling #264

Merged
merged 15 commits into from Oct 31, 2022

Conversation

utsav00
Copy link
Contributor

@utsav00 utsav00 commented Oct 23, 2022

Configure lint checker and prettier and a pre-commit hook

What

  • Modified eslintrc to integrate prettier with it
  • Add it to scripts
  • Add it to the pre-commit hook and test

This installs the following additional packages:

How to test

  • Rename pre-commit.sample to pre-commit and move it to .git/hooks/

Link to issue this resolves

@utsav00
Copy link
Contributor Author

utsav00 commented Oct 23, 2022

@ageddesi, I have few questions:

  1. The target branch is supposed to be dev but I create the branch off master and hence why additional commits. Should I rebase this branch or is it alright to just wait for dev to get merged and the commit difference will be resolved automatically. And then, I can update the conflicts.
  2. The branch name prefix is issues and not feature which is my mistake. Should I rename it or is it okay to keep it?

@ageddesi
Copy link
Owner

HI @utsav00 , Dev is our main branch and where everyones code gets checked into. We only use master when we want to do a release. So Ideally the check so be on Dev.

@utsav00
Copy link
Contributor Author

utsav00 commented Oct 26, 2022

Noted @ageddesi. I've merged the dev branch to this branch. Awaiting workflow run approval and reviews.

@computamike
Copy link
Collaborator

Resolved the merge conflict

@ageddesi ageddesi merged commit ebab547 into ageddesi:dev Oct 31, 2022
@computamike
Copy link
Collaborator

Thanks for fixing my mess up (missing character)

@utsav00 utsav00 deleted the issues/32-lint branch February 9, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup a prettier and eslint pre-commit hook
4 participants