Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product module api test cases and code issue resolved #172

Merged
merged 3 commits into from
Oct 10, 2022
Merged

product module api test cases and code issue resolved #172

merged 3 commits into from
Oct 10, 2022

Conversation

darkl1ght
Copy link
Contributor

Hi @ageddesi, Kindly review this PR for the requested issue #123.

Removed /quantity path from endpoint /products/quantity/:qty, as per the comment from root repo.
ageddesi
ageddesi previously approved these changes Oct 8, 2022
@ageddesi
Copy link
Owner

ageddesi commented Oct 8, 2022

Hi @darkl1ght Just seems to be a couple of conflicts. If you can resolve them please this will get pulled in :)

Copy link
Contributor Author

@darkl1ght darkl1ght left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ageddesi Merge Issues have been resolved. Please review and approve the changes.

@ageddesi ageddesi merged commit 4d32b8c into ageddesi:dev Oct 10, 2022
@ageddesi
Copy link
Owner

Hi @darkl1ght , thank you for the hard work on this 👍 Happy hacktoberfest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants