Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide with steps to add an api endpoint #245

Merged
merged 6 commits into from
Oct 19, 2022

Conversation

bpvcode
Copy link

@bpvcode bpvcode commented Oct 19, 2022

Describe what to do

  • How to add an endpoint
  • How our folders are structured
  • How to add tests - Replace information from README.md to CONTRIBUTING.md
  • How to add OpenAPI comments
  • Change the commit messages section from README.md to CONTRIBUTING.md

Issue to resolve

#46

@bpvcode
Copy link
Author

bpvcode commented Oct 19, 2022

Hello @ageddesi

I am late on this, but already working on issue #46 as we talk :)
This is just a draft for now, but I am planning to have this done by the end of the day :)
Can you please assign this PR to me? Probably because I'm not a maintainer I can't assign an assignee or a reviewer.

Thank you :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
@bpvcode bpvcode marked this pull request as ready for review October 19, 2022 20:45
@bpvcode
Copy link
Author

bpvcode commented Oct 19, 2022

Hello @ageddesi ,

Everything is done now :)

Please review and if you need something else just tell me.

Thanks :)

@ageddesi ageddesi merged commit 090cfd0 into ageddesi:dev Oct 19, 2022
@ageddesi
Copy link
Owner

Hi @bpvcode Perfecto, thank you for contributing 👍 Happy Hacktoberfest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants