Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Chuck Norris Endpoint Feature #261

Merged
merged 24 commits into from
Oct 24, 2022
Merged

Adding Chuck Norris Endpoint Feature #261

merged 24 commits into from
Oct 24, 2022

Conversation

computamike
Copy link
Collaborator

Describe your changes

  • Adding a Chuck Norris Fact end point.
  • Also added static file support to express, so that I could add a warning icon to the endpoint. This offers the ability to limitedly link static files and add them into the mark up. If this is not required, or not suitable - happy to remove.

Link to issue this resolves

Fixes #236

Screenshot of changes(if relevant)

image

@computamike
Adding static file support
a9ac56c
@computamike
adding chucknorris.io
703ecdb
@computamike
scrape script - grab some Chuck Norris facts from api.chucknorris.com
29f1f9d
@computamike
End point - category list doesn't work (yet)
8f91e6e
@computamike
Updating Chuck Norris End Point
9338338
@computamike
Updating tests
1684ab1
@computamike
adding fact file, fixing test
8f8927f
@computamike
remove unused code
57caae6
@computamike
fact downloader refactored.
64585e8
@computamike
Merge branch 'dev' into chuck-norris
bf88f55
@computamike
Somehoe I managed to move Chuck Norris :
7498ffd 
I'm sure we're all aware about what happens when the unstoppable force meets the immovable object? This is a trick question, for there can never be two of Chuck Norris.
@computamike
Chuck Norris tests were outputtig to console.
9f7b472
@computamike
Updating swagger interface -
f82aaeb 
replaced the icon with a beter icon from google Matterial Symbols

https://fonts.google.com/icons?selected=Material%20Symbols%20Rounded%3Awarning%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4048
@computamike
Merge pull request #1 from computamike/chuck-norris
9a3687b 
Chuck norris
ageddesi
ageddesi requested changes Oct 23, 2022
View reviewed changes
src/modules/chuck-norris/api/chuck-norris-routes.ts Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
src/modules/chuck-norris/utils/scrape-facts.ts Show resolved Hide resolved
src/modules/chuck-norris/categories.ts Outdated Show resolved Hide resolved
src/modules/chuck-norris/categories.ts Outdated Show resolved Hide resolved
ageddesi
ageddesi previously approved these changes Oct 23, 2022
View reviewed changes
@ageddesi ageddesi merged commit c6f6566 into ageddesi:dev Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ageddesi ageddesi ageddesi approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chuck Norris Endpoint
2 participants
@computamike @ageddesi