Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new-api-ligue-1-football-teams #282

Merged
merged 2 commits into from
Oct 26, 2022
Merged

new-api-ligue-1-football-teams #282

merged 2 commits into from
Oct 26, 2022

Conversation

ade1705
Copy link
Contributor

@ade1705 ade1705 commented Oct 26, 2022

Hi,

Added a Ligue 1 API and tests for the API.

Related to #270

@what-the-diff
Copy link

what-the-diff bot commented Oct 26, 2022

  • Added a new endpoint to get teams from the Ligue 1 football league
  • Added data for the Ligue 1 football league
  • Updated tests to include testing of this new endpoint

computamike
computamike reviewed Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@computamike computamike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have had a look through the coding, and it seems fine as far as I can see - approving

@computamike computamike merged commit 1e353e4 into ageddesi:dev Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@computamike computamike computamike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ade1705 @computamike