Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the full-status api to use swagger spec for counts #343

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

VinayJariya
Copy link

@VinayJariya VinayJariya commented Jun 12, 2023

Resolves Issue #300 .
Updated swagger category
Updated endpoint to use data from swaggerSpec (same as astro)

@VinayJariya VinayJariya changed the base branch from main to dev June 12, 2023 11:45
@what-the-diff
Copy link

what-the-diff bot commented Jun 12, 2023

PR Summary

  • Addition of new tags in API documentation
    New tags have been added to the swagger.json file, improving the API documentation.
  • Dynamic calculation of app status endpoint values
    The app status endpoint now fetches total categories, endpoints, and version number directly from the swaggerSpec object, removing the need for hardcoded values.
  • Removal of outdated import
    An obsolete import for an old Swagger file has been removed, as the current project utilizes a custom-generated swaggerSpec from the utils/swagger module.

ageddesi
ageddesi previously approved these changes Jun 13, 2023
Signed-off-by: Aaron Rackley (EverydayTinkerer) <aaron.rackley9@gmail.com>
@ghost
Copy link

ghost commented Jun 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ageddesi ageddesi merged commit 8b2d96d into ageddesi:dev Jun 13, 2023
2 checks passed
@ageddesi
Copy link
Owner

Hey @VinayJariya Thank you for your contribution to the platform

@VinayJariya
Copy link
Author

Hey @VinayJariya Thank you for your contribution to the platform

Happy to contribute 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants