Adds author, date, copyright extraction #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philgooch
commented
Feb 15, 2016
philgooch
commented
- Uses metadata fields and classes to extract publication date
- Uses metadata fields to extract authors
- Uses class names to attempt to extract copyright line
- Widens search scope for fallback title extraction (h1, h2)
- Adds softTitle field with less aggressive truncation
* Uses metadata fields and classes to extract publication date * Uses metadata fields to extract authors * Uses class names to attempt to extract copyright line * Widens search scope for title extraction (h1, h2) * Adds softTitle field with less aggressive truncation
|
Thanks for the PR! These features look really useful. Can you also update the README.md file to reflect the new data elements returned? The
Thanks! |
* Updates Shovel Knight review JSON example with new data elements * Moves og:site_name into separate publisher field (semantically more correct)
* Correctly falls back to named author in the body text * Adds unit test for fallback author
* Byline class is used by a number of news sources to identify the author
* Removes wildcard 'date' class matchers * Adds itemprop*='datePublished' matchers * Adds additional '|' copyright chunk delimiter
* Don't create author list containing an empty string * Output null field values rather than empty strings * Don't assume that copyright information is present!
|
Looking forward to this being merged in! |
Closed
|
Thanks! Didn't see this earlier because github doesn't alert you when new commits are merged. |
ageitgey
added a commit
that referenced
this pull request
Feb 20, 2016
Adds author, date, copyright extraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.