Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BloodAlcoholContent #1

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

danielkaldheim
Copy link
Contributor

Added BloocAlcoholContent quantity type. Added also some of the missing typescript types.

@danielkaldheim danielkaldheim marked this pull request as draft September 29, 2020 20:29
Changed BAC method name to getLatestBloodAlcoholContent, added getBloodAlcoholContentSamples. Added docs.
@danielkaldheim danielkaldheim marked this pull request as ready for review September 29, 2020 20:52
@lucaspbordignon lucaspbordignon added the enhancement New feature or request label Sep 30, 2020
Copy link
Contributor

@lucaspbordignon lucaspbordignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @danielkaldheim! Thank you for both the BloodAlcoholContent addition and the type definitions for the existing functions

): void

isAvailable(callback: (error: Object, results: boolean) => void): void

// initStepCountObserver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we could probably remove this comment, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that can be removed :)

@lucaspbordignon lucaspbordignon self-assigned this Sep 30, 2020
@lucaspbordignon lucaspbordignon merged commit 079045c into agencyenterprise:master Sep 30, 2020
macelai pushed a commit that referenced this pull request Apr 5, 2021
macelai pushed a commit that referenced this pull request Aug 4, 2022
Update RCTAppleHealthKit+TypesAndPermissions.m
alancmclean pushed a commit to alancmclean/react-native-health that referenced this pull request Oct 4, 2022
…-read-write

Feature: read workout data from apple health
RuanAzevedo added a commit that referenced this pull request Jan 4, 2023
GGGava pushed a commit that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants