Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Peak Flow rate #135

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Add support for Peak Flow rate #135

merged 4 commits into from
Jan 23, 2023

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Jul 21, 2021 •
edited

Description

This PR adds support for Peak Expiratory Flow rate to react-native-health library.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

Screenshots:

image

@kabaros kabaros changed the title Add support for Peak Flow Expiratory Rate Add support for Peak Flow rate Jul 21, 2021
macelai
macelai requested changes Jul 23, 2021
View reviewed changes
Copy link
Member

@macelai macelai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Can you also add docs to docs/README.md and docs/permissions.md?

Thanks!

@GGGava GGGava added this to To do in Roadmap via automation Jan 23, 2023
@GGGava
Code review changes suggested by @AugustoRamos94:
b3b7ba2 
- Removed unnecessary 'return'
- Checking for error instead of checking value before calling error callback
@GGGava
- Added missing documentation
cf3d46b
@GGGava
Merge branch 'master' into feature/peak-flow
ba27710
@GGGava GGGava requested review from macelai and removed request for lucaspbordignon January 23, 2023 19:21
@GGGava GGGava assigned GGGava and unassigned lucaspbordignon and macelai Jan 23, 2023
@GGGava GGGava added the enhancement New feature or request label Jan 23, 2023
@GGGava GGGava merged commit 77554da into agencyenterprise:master Jan 23, 2023
Roadmap automation moved this from To do to Done Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustoRamos94 AugustoRamos94 AugustoRamos94 left review comments

@GGGava GGGava GGGava approved these changes

@macelai macelai macelai approved these changes

Assignees

@GGGava GGGava

Labels
enhancement New feature or request
Projects
Roadmap
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kabaros @AugustoRamos94 @GGGava @macelai @lucaspbordignon