Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added saveHeartRateSample to the library #163

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

Nesh108
Copy link

@Nesh108 Nesh108 commented Sep 30, 2021

Description

Added saveHeartRateSample to the library.

Fixes #162

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@Nesh108 Nesh108 closed this Sep 30, 2021
@Nesh108 Nesh108 reopened this Oct 1, 2021
Copy link
Contributor

@AugustoRamos94 AugustoRamos94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

RCTAppleHealthKit/RCTAppleHealthKit+Methods_Vitals.m Outdated Show resolved Hide resolved
RCTAppleHealthKit/RCTAppleHealthKit+Methods_Vitals.m Outdated Show resolved Hide resolved
RCTAppleHealthKit/RCTAppleHealthKit+Methods_Vitals.m Outdated Show resolved Hide resolved
RCTAppleHealthKit/RCTAppleHealthKit+Methods_Vitals.m Outdated Show resolved Hide resolved
@shmkane
Copy link
Contributor

shmkane commented Feb 5, 2022

Is this still being worked on? Would be a nice function to have.

@Nesh108
Copy link
Author

Nesh108 commented Feb 9, 2022

@shmkane I haven't had the time to apply the proposed additions. I might try to look into it when I get down to it :D

@Nesh108
Copy link
Author

Nesh108 commented Feb 9, 2022

@AugustoRamos94 I applied the changes requested 👍 Let me know.

@GGGava GGGava merged commit fcb9831 into agencyenterprise:master Jul 3, 2023
Copy link

@iamandiradu iamandiradu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to save Heart Rates?
6 participants