Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add HK RunningSpeed to permissions #249

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

walterholohan
Copy link
Contributor

Description

We use react-native-health to ask users to accept HK permissions of metrics that we use in our Apple Watch app. In WatchOS9 'RunningSpeed' was released which will return the pace of the user while running outside. This PR exposes the new metric to the Permissions module of this library

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@walterholohan
Copy link
Contributor Author

@GGGava can you take a look at this PR please?

@RuanAzevedo RuanAzevedo changed the base branch from master to development January 25, 2023 15:29
@vojto
Copy link

vojto commented May 22, 2023

+1

if this repo is not maintained, perhaps worth considering https://github.com/kingstinct/react-native-healthkit

@macelai
Copy link
Member

macelai commented May 30, 2023

hey @vojto, we do not have active people working on this repo, but we are open to add more maintainers.

@GGGava GGGava changed the base branch from development to master July 3, 2023 12:04
@GGGava
Copy link
Collaborator

GGGava commented Jul 3, 2023

Hey @walterholohan thank you very much for your contribution and I'm really sorry for the time I took to review your PR. Could you fix the conflicts in this PR so I can merge it? thanks :D

@walterholohan
Copy link
Contributor Author

@GGGava conflicts now resolved

@walterholohan
Copy link
Contributor Author

+1

if this repo is not maintained, perhaps worth considering https://github.com/kingstinct/react-native-healthkit

@vojto thank you for this, and something we will look into. As currently, react-native-health does not support saving a full workout to healthKit but I can see that this library does or seems to do with saveWorkoutSample

@GGGava GGGava merged commit badbb5c into agencyenterprise:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants