Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript errors in index.d.ts #288

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

kristerkari
Copy link
Contributor

@kristerkari kristerkari commented Feb 13, 2023

Description

Fixes two typescript errors from index.d.ts file.

Changes

  • Remove unused import
  • Add undefined to RecordMetadata index signature

Errors reported by Typescript

Output from Typescript compiler:

tsc

Unused import:

unused

Index signature not including undefined:

index-signature

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

ping @GGGava @RuanAzevedo

@GGGava GGGava self-requested a review February 27, 2023 14:46
@GGGava
Copy link
Collaborator

GGGava commented Feb 27, 2023

Thank you 😄

@GGGava GGGava merged commit 3c4b87d into agencyenterprise:master Feb 27, 2023
@kristerkari kristerkari deleted the fix-typescript-errors branch February 28, 2023 01:54
@kristerkari
Copy link
Contributor Author

@GGGava any chance for a new release with the recent fixes included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants