Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getFiberSamples #299

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Add getFiberSamples #299

merged 1 commit into from
Jul 3, 2023

Conversation

hstaudacher
Copy link
Contributor

Description

This PR adds support for getting fiber values the same way as getting e.g. protein. Also the README.md was updated and docs added for the new fiber support.

Fixes #273

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have checked my code and corrected any misspellings

@LuisDanielCova
Copy link

When is this getting merged? I would like to use it for an app

@francoangulo
Copy link

Any update on this? I need to use this in my application also @GGGava

@jesusamaro25
Copy link

Any update on this? I also need this.

@macelai
Copy link
Member

macelai commented May 30, 2023

did anyone try out this PR?

@GGGava GGGava self-assigned this Jun 30, 2023
@GGGava GGGava self-requested a review July 3, 2023 10:07
@GGGava
Copy link
Collaborator

GGGava commented Jul 3, 2023

Amazing! Thank you for your contribution 😄

@GGGava GGGava merged commit b1aaf5f into agencyenterprise:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix API inconsistency by allowing to get fiber samples
6 participants