Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution failure due to port number. #70

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Execution failure due to port number. #70

merged 1 commit into from
Feb 18, 2020

Conversation

geosp
Copy link
Collaborator

@geosp geosp commented Feb 18, 2020 •
edited

Fixes #69 by:

  • Refactor the handling of the URL pattern, associated path and query information.
  • Change the wording in the documentation to make the path and query matching feature easier to understand.
  • Add options information to the failure message to facilitate identification of failure root cause.

@keyvan-m-sadeghi
Copy link
Member

Looks great, thanks @geosp!

@keyvan-m-sadeghi keyvan-m-sadeghi merged commit a5accfb into agenda:master Feb 18, 2020
@geosp geosp mentioned this pull request Feb 18, 2020
Open
@geosp geosp deleted the hotfix/execution_failure_due_to_port_number branch October 9, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyvan-m-sadeghi keyvan-m-sadeghi Awaiting requested review from keyvan-m-sadeghi

@OmgImAlexis OmgImAlexis Awaiting requested review from OmgImAlexis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The job fails when specifying port number, parameters and query strings.
2 participants
@geosp @keyvan-m-sadeghi