-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring agendaTS into agenda main repo #1502
Comments
What about tests? |
@simllll I hope this will be a starting point. |
@simllll Is there any update on this issue? |
Sorry for still not working on it, I have it still in my list, but couldn't really find time yet. Hopefully within the next few weeks though! |
@simllll Is this on the agenda ? (Pun intended) |
It's still on my list, but unfortunately didn't find time yet... Maybe I can start working on it next weekend, to get things rolling... 🤞 |
@simllll let me know if you need anything. I will try to find time to help out if possible |
Hi there, Would it be possible to create a I think it would be nice to add support for |
@simllll Is there any update on this? |
I'm curious on where I should get agenda as well. Looks like npmjs is showing version 5.0.0 only, but this repo shows change logs into the 6.X @simllll |
@GimpMaster the 6.x development halted unfortunately. |
@koresar - is the 5.X considered stable? I’m still back on 3.X and was just looking to upgrade. |
I do not know which is more stable. Sorry. |
@GimpMaster 5.x is stable, but it doesn't work with I've published my own fork @whisthub/agenda on npm, which is compatible with mongodb 4, 5 and 6 (beware mongodb is a peer dependency now). I've been using this in production for about 3 weeks now without any issues. |
Thank you |
@sebamarynissen thanks for that, got excited for a moment but because your fork is ESM only, it doesn't work with NestJS :( Hopefully NestJS will move to ESM one of these days... |
@tomups Is it an option for you to use dynamic import? As most of agenda is async anyway, this could be an option in cjs projects: const { default: agenda } = await import('@whisthub/agenda');
await agenda.start();
// Instead of
const agenda = require('@whisthub/agenda');
await agenda.start(); |
@sebamarynissen I don't use agenda directly in NestJS but via https://github.com/jongolden/agenda-nest which makes it work in a more NestJS way. So I don't think using dynamic import in that way would work. Maybe forking agenda-nest and trying it... But with dynamic import we lose TypeScript types :( |
As discussed and suggested here #1082 the idea is to bring agendaTS as new major version of agenda main.
Checklist (WIP):
New features in agendaTS:
List of currently known breaking changes:
shouldSaveResult
hokify/agenda#29)const collection = agenda._collection?.collection || genda._collection || agenda.db?.collection;
see agendash not working with this fork hokify/agenda#27feel free to add comments, ideas and other things you come up with :)
The text was updated successfully, but these errors were encountered: