Run job between start and end date + run job every x days #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to achieve the following scenarios: - Every x days at 8:00 AM CST starting 30-Aug-2016 - Daily at 8:00 AM CST starting 30-Aug-2016 - Every Wed and Fri at 8:00 AM CST Starting 30-Aug-2016
|
Hmm, you've changed indentation from 2 to 4 all over the place. |
|
Ah! I didn't realize that. Sorry about that. |
|
I think you need to fix that indentation issue before your PR will be reviewed and merged. I need that feature too, so i would be glad if the merge happens soon. |
|
I have fixed the indentation for job.js but not able to fix it for the test/agenda.js. Can some one help? |
|
@suryanaik if you'd like to rebase this I'll be happy to review and look at getting this merged. |
|
will try to update this PR to work with current TS version. |
leonardlin
reviewed
Dec 28, 2020
leonardlin
reviewed
Dec 28, 2020
leonardlin
reviewed
Dec 28, 2020
leonardlin
reviewed
Dec 28, 2020
Merged
simllll
reviewed
Dec 28, 2020
|
overall looks good to me, just some small comments, but nothing that is blocking at all 👍 |
leonardlin
approved these changes
Dec 28, 2020
This was referenced Jan 12, 2021
Closed
xenokratos
pushed a commit
to beedeez/agenda
that referenced
this pull request
Mar 23, 2021
* Modified job.repeatEvery to include startDate and skipDate in the option to achieve the following scenarios: - Every x days at 8:00 AM CST starting 30-Aug-2016 - Daily at 8:00 AM CST starting 30-Aug-2016 - Every Wed and Fri at 8:00 AM CST Starting 30-Aug-2016 * Fixed failing test * Added endDate options * Fixed missing endDate * Changed the indentation to 2 from 4 * Update agenda.js * Update agenda.js * added tests and typescript Co-authored-by: Surya Naik <surya.naik@saviance.com> Co-authored-by: Leonard Lin <leonard@linhome.ch>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified job.repeatEvery to include startDate, endDate and skipDays in the option to achieve the following scenarios:
Will not disrupt existing users.