Add Node.js v16 in tests #1314
Merged
Add Node.js v16 in tests #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related, updating to Node.js v16 in Docker container: #1306 |
|
I'd rather not rush with deprecating things without an actual need. A need could be :
Chances are, there are a lot of people using Agenda in node 10 or even 8. Also, having this PR merged would probably mean we have to release another MAJOR. It's too many major releases as to my taste Let's just add node 16 at this stage. |
|
Fair enough! Thanks for thinking it through. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Node.js v16 into test rig.
Happy to keep v10 if anyone thinks it's still important. It's no longer maintained. Edit: we're keeping it.
https://nodejs.org/en/about/releases/
Meanwhile, let's start test for new LTS active.