Emit ready event when using config.mongo

[loris]

config.mongo is doing synchronous work, but added ready event for being consistent with config.db behavior (#213 (comment))

[jdiamond]

Testing this PR. Did you mean to add the "failCount" commit? Doesn't seem related to the ready event feature.

[loris]

No actually, it was meant for another PR but both ended up on my fork
master branch. I will fix that as soon as I get a computer.

[jdiamond]

So this fix doesn't really work because it emits the ready event before the Agenda constructor has a chance to return. Since I can't call .on('ready') until the constructor returns, I miss it.

I think moving the emitting of the ready event to db_init() (after the indexes are created) might be better so that it only has to be in one spot. As it is now, it's possible to not pass in a config object to the constructor and use the database() or mongo() methods to set those options. They end up calling db_init(), but don't emit the ready event.

[jdiamond]

I took a crack at this here:

https://github.com/jdiamond/agenda/tree/ready-event

Can submit a PR if you think it's a good approach.

[loris]

@jdiamond You right, this is the best approach, I will close this PR and test yours on my setup.
Thanks!

[Pyrolistical]

is there a workaround before this is fixed?

[rschmukler]

@jdiamond please submit a PR upstream and I'll merge in!