Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'xo' and formatted all files to comply with linting #474

Closed
wants to merge 3 commits into from

Conversation

emhagman
Copy link
Contributor

@emhagman emhagman commented Jul 19, 2017

I went ahead and added the xo library. The linting is ran in the test script in package.json. I also added a command called autoformat that will do most of the heavy lifting for most people when trying to adhere to the style guidelines. There is a convenience method called lint as well. All of these can be run via npm run [name] like npm run lint.

I know #455 discusses this and believe this will close it out as long as everyone agrees this is the code formatting / linting tool we want to use.

If anything needs to change let me know!

@coveralls
Copy link

coveralls commented Jul 19, 2017

Coverage Status

Coverage decreased (-0.7%) to 90.875% when pulling ebe7b52 on draftedus:xo-lint into d8e1da3 on agenda:master.

@emhagman
Copy link
Contributor Author

emhagman commented Jul 19, 2017

I just saw #471, should I close this?

@emhagman emhagman closed this Jul 19, 2017
@emhagman emhagman reopened this Jul 19, 2017
@coveralls
Copy link

coveralls commented Jul 19, 2017

Coverage Status

Coverage decreased (-0.9%) to 90.689% when pulling ebe7b52 on draftedus:xo-lint into d8e1da3 on agenda:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 90.689% when pulling ebe7b52 on draftedus:xo-lint into d8e1da3 on agenda:master.

@OmgImAlexis
Copy link
Member

Yep close. I'll redo this once more of the higher priority PRs get merged. Sorry for you adding this extra work. 😞

@emhagman emhagman deleted the xo-lint branch July 27, 2017 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants