Add Koa support #148
Merged
Add Koa support #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2021
Closed
Closed
simison
reviewed
Jan 22, 2021
|
|
||
| t.false('newJobs' in response.body); | ||
|
|
||
| const count = await agenda._collection.count({}, null); |
There was a problem hiding this comment.
Note that count() is deprecated (it's countDocuments() or something like that now), but it's not urgent.
There was a problem hiding this comment.
It's deprecated, but countDocuments() does not exist in the smallest MongoDB version we support - 2.6.
New in version 4.0.3.
|
Had a cursory look — all good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84
This PR also explains in README.md how to add Agendash to Koa or Hapi servers.