Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vite; Add TypeScript #157

Merged
merged 1 commit into from Aug 28, 2021
Merged

Use Vite; Add TypeScript #157

merged 1 commit into from Aug 28, 2021

Conversation

agentcooper
Copy link
Owner

@agentcooper agentcooper commented Aug 28, 2021

Legacy path is now used for pdfjs-dist, that closes #155 and #147.

Added TypeScript support, closes #107 and #61.

The new build is shipped without CSS imports and that should fix #156.

String ref is also gone, closes #108.

@agentcooper agentcooper merged commit 428479e into master Aug 28, 2021
@agentcooper agentcooper deleted the vite-typescript branch August 28, 2021 17:05
@Fensterbank
Copy link
Contributor

nice work, thanks. 👏
This makes contributing easier and I'll test if it fixes some of the issues I had.

@adeperio
Copy link

adeperio commented Jan 7, 2022

Hi! Just wanted to see where the status of the NextJS CSS issue was (#156). I've got the latest 5.3.0 version and I am still seeing the global css problem on NextJS. Just wondering if there was a fix for this published to NPM? Or is this still an open issue? Thanks :)

sarcXD pushed a commit to sarcXD/react-pdf-highlighter that referenced this pull request Jan 28, 2022
@ACruzana
Copy link

ACruzana commented Sep 9, 2022

Hello there, issue seems to be still there:
image
is there any plans to change this in the short future?

Is there any workaround for using this on next.js?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants