Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boolean field rewrite #1097

Merged
merged 1 commit into from May 9, 2019
Merged

Conversation

raffaelj
Copy link
Contributor

@raffaelj raffaelj commented May 7, 2019

  • semantic markup - label is now an actual, clickable label
  • removed some js - not necessary anymore
  • changed CSS
    • moved switch into :before/:after
    • minor changes (em instead of px)
    • added :focus for visibility when using tab key

* semantic markup - label is now an actual, clickable label
* removed some js - not necessary anymore
* changed CSS
* moved switch into :before/:after
* minor changes (em instead of px)
* added :focus for visibility when using tab key
@raffaelj
Copy link
Contributor Author

raffaelj commented May 7, 2019

Clicking on the boolean field label is possible again after I changed the switch from onclick to onchange in #1007.

I addressed this before in #1036, but reverted it later. Now I changed the CSS properly.

@aheinze aheinze merged commit 6b7c6fb into agentejo:next May 9, 2019
@aheinze
Copy link
Member

aheinze commented May 9, 2019

Thanks!

@raffaelj raffaelj deleted the rewrite-boolean-field branch June 11, 2019 11:32
pherrymason pushed a commit to pherrymason/cockpit that referenced this pull request May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants