Upgrade path #110
Merged
Upgrade path #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larowlan
reviewed
Mar 12, 2018
| ]); | ||
| $scheme->save(); | ||
| } | ||
|
|
||
| \Drupal::state()->set('workbench_access_upgraded_scheme_id', 'default'); |
There was a problem hiding this comment.
This should go inside the else above it, otherwise the legacy views stuff will kick in and try to load a non-existent scheme
There was a problem hiding this comment.
I accounted for that in the change to workbench_access_views_data_alter() above, which only fires if the default scheme is set.
I think this comment might be on an outdated commit.
There was a problem hiding this comment.
Yes, I moved it in a later commit.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some smoother handling of upgrades, based on recent error reports.