Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run should operate on generic models #37

Closed
dhixsingh opened this issue Jun 11, 2019 · 1 comment
Closed

Run should operate on generic models #37

dhixsingh opened this issue Jun 11, 2019 · 1 comment
Assignees

Comments

@dhixsingh
Copy link
Contributor

At the moment the Run class holds explicitly named instances of different models. This should be standardised into list of Models on which the init/step/finish should be called.

As part of this we also want to allow users applications to swap out default models with their own. This has become apparent in the social network diffusion work.

@dhixsingh
Copy link
Contributor Author

There is now an interim mechanism to override models using the withModel function. Example usage is below:

new Run()
.withModel(DataServer.getInstance(DATASERVER))
.withModel(new DiffusionModel(cfg.getModelConfig(Config.eModelDiffusion), DataServer.getInstance(DATASERVER), new ArrayList<>(bdiMap.keySet())))
.start(cfg, bdiMap);

/cc @chambul

dhixsingh added a commit that referenced this issue Jun 16, 2019
@dhixsingh dhixsingh closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant