Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing output value in 03_classification #2

Closed
velaris1 opened this issue Apr 5, 2019 · 1 comment
Closed

Missing output value in 03_classification #2

velaris1 opened this issue Apr 5, 2019 · 1 comment

Comments

@velaris1
Copy link

velaris1 commented Apr 5, 2019

Hi,

This issue applies to Chapter 3's code sample (i.e.: 03_classification).

When calculating the desired threshold value for a precision >= 0.09, the following is done:

threshold_90_precision = thresholds[np.argmax(precisions >= 0.90)]

Right after this statement, the following is written:

threshold_90_precision

Correct me if I'm wrong, but I believe this was done in order to demonstrate that the threshold in question is equal to 7816.155523682526 (note: 7813 is used in the graph examples / shown in comments, so there's a disparity there).

The issue is that the output is missing.

Thanks,
Hussein Khalil

@ageron
Copy link
Owner

ageron commented Apr 5, 2019

Hi @velaris1 ,
Good catch, thanks a lot! 👍
Indeed, the comment says 7813, but it should be ~7816.
I'll fix this now, and add the missing outputs.

@ageron ageron closed this as completed in 12c8218 Apr 5, 2019
lzhang12 pushed a commit to lzhang12/handson-ml2 that referenced this issue Dec 12, 2019
ustchope added a commit to ustchope/handson-ml2 that referenced this issue Aug 17, 2021
ustchope added a commit to ustchope/handson-ml2 that referenced this issue Aug 18, 2021
ustchope added a commit to ustchope/handson-ml2 that referenced this issue Aug 20, 2021
ustchope added a commit to ustchope/handson-ml2 that referenced this issue Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants