Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Input Availability #150

Closed
wants to merge 44 commits into from
Closed

Conversation

firejake308
Copy link
Collaborator

Users can now input their availability using the <Schedule /> component.

Closing #122

@firejake308 firejake308 added feature Something that adds new functionality frontend Anything related to the frontend - React, etc labels Feb 19, 2020
@firejake308 firejake308 added this to the Frontend v0.2 milestone Feb 19, 2020
@firejake308 firejake308 self-assigned this Feb 19, 2020
@github-actions
Copy link

github-actions bot commented Feb 19, 2020

Warnings
⚠️ ❗ Big PR! You might want to split this up into separate commits in order to maximize the effectiveness of code review

Generated by 🚫 dangerJS against a06839b

@gannonprudhomme
Copy link
Member

While functionally this looks great (although rn it's making every time box you drag default to 30 min), this is a pretty huge PR, and if we review this in one piece I feel like it'll become a #94 with a bunch of comments and become hard to jumble all the changes. As such, could you try to split this up into ~2-3 logical pieces if possible? I know given the nature of React + Redux so many of the changes are tied together, but I don't think we can effectively review this otherwise.

@firejake308
Copy link
Collaborator Author

I fixed the bug in the latest commit, and to make the reviewing process more reasonable, please review PR #151 before this one

@firejake308 firejake308 force-pushed the frontend/availability branch 2 times, most recently from 5e97a61 to 9d2ec3e Compare March 1, 2020 05:45
@rachelconn
Copy link
Collaborator

rachelconn commented Mar 2, 2020

Here are my comments from the meeting:

  • Can still create availabilities before 8 AM or past 9 PM
  • Creating 2 blocks and then one that overlaps both will merge twice
  • Time selection thing should disappear when clicking since you can see the time anyways, or when time is before 8 AM
  • Dragging to create a new availability with same start or end time as an existing one will immediately delete the existing one

@firejake308
Copy link
Collaborator Author

Okay, I've investigated mocking mouse events, and apparently JSDOM supports them, but not well enough to meet our needs. Consequently, there won't be much automatic UI testing for this feature

@firejake308
Copy link
Collaborator Author

Rather than continuously rebasing and force-pushing, I have made a fresh branch and an accompanying PR. See #160.

@firejake308 firejake308 closed this Mar 6, 2020
@gannonprudhomme gannonprudhomme deleted the frontend/availability branch April 7, 2020 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature Something that adds new functionality frontend Anything related to the frontend - React, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants