Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Scraper API Term & Course Search #154

Merged
merged 19 commits into from
Mar 22, 2020

Commits on Feb 20, 2020

  1. implented api/terms and api/course/search

    Results are not yet filtered or sorted in any way before they are returned though
    ThatJuanGuy committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    60ad2e7 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Configuration menu
    Copy the full SHA
    cf4173b View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2020

  1. api/course/search bugs fixed

    -contains changed to startswith so that when 201 is in the 'search' parameter it doesn't return every course that takes in a 201X term instead of courses with the number 201. However, department must be inputted before the course number now.
    
    Suggested formatting and typo fixes
    
    Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com>
    Co-Authored-By: Ryan Conn <rconn478@gmail.com>
    3 people committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    684b689 View commit details
    Browse the repository at this point in the history
  2. Implemented suggested code improvements

    Co-Authored-By: Ryan Conn <rconn478@gmail.com>
    Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com>
    
    Fixes the remaining formatting issues
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    d961660 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec0300a View commit details
    Browse the repository at this point in the history
  4. api/course/search now converts lowercase to upper

    Removes /api/sections and /api/course
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    abfbbc0 View commit details
    Browse the repository at this point in the history
  5. Created additional tests for /api/course/search

    Added test for course names including numbers
    
    Added test for search with lowercase text
    rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    ff10190 View commit details
    Browse the repository at this point in the history
  6. Made course search tests more precise

    Test for "CSCE 3" now has to filter results with non-matching numbers
    
    Added test for lowercase string with numbers ("csce 3")
    
    Updated test for "csce" to include newly added course
    rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    abb959b View commit details
    Browse the repository at this point in the history
  7. Test updates to address suggestions

    Changed setUp method to setUpTestData
    
    Changed model saving to use bulk create
    
    Updated api/terms test to use bulk_create
    
    Made docstrings more descriptive
    rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    7ef3b78 View commit details
    Browse the repository at this point in the history
  8. Moved some helper function definitions outside of TermSerializer

    This was so they could be called in api_tests.py
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    6c807d7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f6be433 View commit details
    Browse the repository at this point in the history
  10. Moved some lines into get_queryset()

    Also deleted some extra empty lines and added pylint silencing comments to get_desc and get_course.
    
    Removed another empty line
    
    Silenced parameters differ pylint warning
    
    Fixes description for test_api_term_serializer_gives_expected_output_professional
    
    Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com>
    2 people authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    ef98019 View commit details
    Browse the repository at this point in the history
  11. Renames helper function tests

    test_api_term_serializer_handles_(un)defined_season_correctly is now called test_season_num_to_string_handles(un)defined_season_correctly to be more clear as to what is actually being tested. This was also done to campus_num_to_string related tests.
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    02e9bef View commit details
    Browse the repository at this point in the history
  12. Code readability improvement

    String formatting to remove spaces in search parameter is now done when search variable is assigned to rather than during the .filter in RetrieveCourseSearchView
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    ed157bb View commit details
    Browse the repository at this point in the history
  13. api/course/search now also handles non %20 spaces

    Fixed description of some tests
    
    The description on some tests was inacurrately referencing section serializer instead of the serializer actually beng tested
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    567bcc4 View commit details
    Browse the repository at this point in the history
  14. Added test for api/course/search to check if non %20 spaces are handl…

    …ed in search parameter
    ThatJuanGuy authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    cff9d39 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7ac6e75 View commit details
    Browse the repository at this point in the history
  16. Made api/sections order_by id to pass tests

    Code readability improvements
    
    Silences "Too many public methods" pylint warning in api_tests.py
    
    Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com>
    
    Removes unecesary department saving in api_tests.py
    
    Code readability improvements
    gannonprudhomme authored and rachelconn committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    f3397d6 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e48742b View commit details
    Browse the repository at this point in the history