-
Notifications
You must be signed in to change notification settings - Fork 5
Commits on Feb 20, 2020
-
implented api/terms and api/course/search
Results are not yet filtered or sorted in any way before they are returned though
Configuration menu - View commit details
-
Copy full SHA for 60ad2e7 - Browse repository at this point
Copy the full SHA 60ad2e7View commit details
Commits on Feb 24, 2020
-
Configuration menu - View commit details
-
Copy full SHA for cf4173b - Browse repository at this point
Copy the full SHA cf4173bView commit details
Commits on Mar 22, 2020
-
-contains changed to startswith so that when 201 is in the 'search' parameter it doesn't return every course that takes in a 201X term instead of courses with the number 201. However, department must be inputted before the course number now. Suggested formatting and typo fixes Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com> Co-Authored-By: Ryan Conn <rconn478@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 684b689 - Browse repository at this point
Copy the full SHA 684b689View commit details -
Implemented suggested code improvements
Co-Authored-By: Ryan Conn <rconn478@gmail.com> Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com> Fixes the remaining formatting issues
Configuration menu - View commit details
-
Copy full SHA for d961660 - Browse repository at this point
Copy the full SHA d961660View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec0300a - Browse repository at this point
Copy the full SHA ec0300aView commit details -
api/course/search now converts lowercase to upper
Removes /api/sections and /api/course
Configuration menu - View commit details
-
Copy full SHA for abfbbc0 - Browse repository at this point
Copy the full SHA abfbbc0View commit details -
Created additional tests for /api/course/search
Added test for course names including numbers Added test for search with lowercase text
Configuration menu - View commit details
-
Copy full SHA for ff10190 - Browse repository at this point
Copy the full SHA ff10190View commit details -
Made course search tests more precise
Test for "CSCE 3" now has to filter results with non-matching numbers Added test for lowercase string with numbers ("csce 3") Updated test for "csce" to include newly added course
Configuration menu - View commit details
-
Copy full SHA for abb959b - Browse repository at this point
Copy the full SHA abb959bView commit details -
Test updates to address suggestions
Changed setUp method to setUpTestData Changed model saving to use bulk create Updated api/terms test to use bulk_create Made docstrings more descriptive
Configuration menu - View commit details
-
Copy full SHA for 7ef3b78 - Browse repository at this point
Copy the full SHA 7ef3b78View commit details -
Moved some helper function definitions outside of TermSerializer
This was so they could be called in api_tests.py
Configuration menu - View commit details
-
Copy full SHA for 6c807d7 - Browse repository at this point
Copy the full SHA 6c807d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6be433 - Browse repository at this point
Copy the full SHA f6be433View commit details -
Moved some lines into get_queryset()
Also deleted some extra empty lines and added pylint silencing comments to get_desc and get_course. Removed another empty line Silenced parameters differ pylint warning Fixes description for test_api_term_serializer_gives_expected_output_professional Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for ef98019 - Browse repository at this point
Copy the full SHA ef98019View commit details -
test_api_term_serializer_handles_(un)defined_season_correctly is now called test_season_num_to_string_handles(un)defined_season_correctly to be more clear as to what is actually being tested. This was also done to campus_num_to_string related tests.
Configuration menu - View commit details
-
Copy full SHA for 02e9bef - Browse repository at this point
Copy the full SHA 02e9befView commit details -
String formatting to remove spaces in search parameter is now done when search variable is assigned to rather than during the .filter in RetrieveCourseSearchView
Configuration menu - View commit details
-
Copy full SHA for ed157bb - Browse repository at this point
Copy the full SHA ed157bbView commit details -
api/course/search now also handles non %20 spaces
Fixed description of some tests The description on some tests was inacurrately referencing section serializer instead of the serializer actually beng tested
Configuration menu - View commit details
-
Copy full SHA for 567bcc4 - Browse repository at this point
Copy the full SHA 567bcc4View commit details -
Added test for api/course/search to check if non %20 spaces are handl…
…ed in search parameter
Configuration menu - View commit details
-
Copy full SHA for cff9d39 - Browse repository at this point
Copy the full SHA cff9d39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ac6e75 - Browse repository at this point
Copy the full SHA 7ac6e75View commit details -
Made api/sections order_by id to pass tests
Code readability improvements Silences "Too many public methods" pylint warning in api_tests.py Co-Authored-By: Gannon Prudhomme <gannonprudhomme@users.noreply.github.com> Removes unecesary department saving in api_tests.py Code readability improvements
Configuration menu - View commit details
-
Copy full SHA for f3397d6 - Browse repository at this point
Copy the full SHA f3397d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e48742b - Browse repository at this point
Copy the full SHA e48742bView commit details