Remove validium dep #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmaroman
approved these changes
Dec 19, 2023
vcastellm
approved these changes
Dec 20, 2023
| @@ -0,0 +1,39 @@ | |||
| package types | |||
There was a problem hiding this comment.
Are we going to get rid-off the go-ethereum dependency at some point? If that is not planned, then we can reuse these functions from it.
christophercampbell
approved these changes
Dec 29, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to integrate beethoven on validium-node, essentialy replacing
cdk-validium-node==>zkevm-node. But also using RPC server from DAC which is much more cleaner (needed anyway to be able to switch to zkevm-node)