Merge 1d7e0ff into a338564

agilecreativity · Nov 23, 2015 · 949f118 · 949f118
2 parents a338564 + 1d7e0ff
commit 949f118
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/filename_cleaner/filename_cleaner.rb b/lib/filename_cleaner/filename_cleaner.rb
@@ -87,8 +87,9 @@ def sanitize_with_dot(name)
 
     # Replace 'dot' string with a given string if specified
     def replace_dot(string, replace = nil)
-      string.gsub!(/#{Regexp.quote(DOT)}+/, replace) if replace
-      string
+      result = string.clone
+      result.gsub!(/#{Regexp.quote(DOT)}+/, replace) if replace
+      result
     end
   end
 end
diff --git a/test/lib/filename_cleaner/test_filename_cleaner.rb b/test/lib/filename_cleaner/test_filename_cleaner.rb
@@ -89,5 +89,12 @@
         end
       end
     end
+    describe "immutability" do
+      it "does not mutate the input" do
+        input_name = "Global Variables"
+        output_name = FilenameCleaner.sanitize(input_name, "_", false)
+        output_name.wont_equal input_name
+      end
+    end
   end
 end