This repository has been archived by the owner on Dec 23, 2022. It is now read-only.
Add unsafe json body parser #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validation in body parser.
|
@haolinj Can you please improve the tests to at least maintain coverage, if not improve it. |
|
@timechanter More tests for the BodyParsers are added. |
| */ | ||
| def whitelistingJson(implicit executionContext: ExecutionContext): BodyParser[JsValue] = parse.json map clean | ||
| def whitelistingJson[A](implicit executionContext: ExecutionContext, reader: Reads[A]): BodyParser[A] = parse.json map clean validate as[A] |
There was a problem hiding this comment.
I think that we probably want to leave the variants without type parameters in place.
|
@danielnixon Added the non-type parameter parser back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And added type validation in body parser.