Ensure all relvant SQS/SNS CloudFormation attributes are mapped through

[NoxHarmonium]

Seems like people keep finding attributes that aren't mapped through:
E.g.

#205
#82
#28

We should go through and check if there are any more useful attributes we need to map through

[denise-sanders]

Is there a philosophy around which attributes you want to support? I was using your plugin and was thinking about implementing

• enabled (I wrote a pr here feat: add enabled option #219)
• queue retention on the main queue instead of just the dlq (although it's probably not that important for most people)
• fifo queue support

[NoxHarmonium]

Is there a philosophy around which attributes you want to support?

I was thinking of just going through the CloudFormation documentation and mapping everything through or maybe just make it more dynamic so we can just pass arbitrary properties through to the CloudFormation template, but that sounds error prone.
Until we find the time to do that, every bit counts though!

enabled (I wrote a pr here #219)

Thanks we'll have a look 🚀

fifo queue support

That sounds important, that might be a good next one to map through.

[NoxHarmonium]

There are heaps of useful parameters on the event mapping too that we need to map through (or allow some override)

BisectBatchOnFunctionError in particular is super useful

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-lambda-eventsourcemapping.html

[NoxHarmonium]

Oh it turns out that "BisectBatchOnFunctionError" is only a feature if you're subscribing to Kinesis streams.

[NoxHarmonium]

@robinMcA @dbalmain what are your thoughts on https://github.com/agiledigital/serverless-sns-sqs-lambda/tree/pass-through-cf-params ?
If you like that approach I can clean it up and raise a PR.

[dbalmain]

Love it! This is a great idea.

[NoxHarmonium]

🎉 This issue has been resolved in version 0.6.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀