Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of Serverless Framework v3 #540

Closed
stefan-rode opened this issue Apr 8, 2022 · 2 comments
Closed

Support of Serverless Framework v3 #540

stefan-rode opened this issue Apr 8, 2022 · 2 comments
Labels
released

Comments

@stefan-rode
Copy link

Hi,
thank you for providing this npm package.
Would it be possible for you to check if your package works with Serverless Framework v3 as well and update the peer dependency in you package.json ?
That would be great, because currently the upgrade from Serverless Framework v2 to v3 is blocked for me.

Best regards

Stefan
NoxHarmonium added a commit that referenced this issue May 2, 2022
@NoxHarmonium
feat: upgrade to serverless v3 (#540)
63e3ea2 
BREAKING CHANGE: serverless v2 is no longer supported. It might still work, but bug fixes/new features will mostly be developed for and tested with serverless v3 (important security/bug fixes _may_ be back ported to v2 versions depending on the uptake of v3)

serverless v3 is now a peer dependency, you will get warnings if you are on earlier versions
@NoxHarmonium
Copy link
Collaborator

Hi @stefan-rode, sorry about the delay.
It looks like the upgrade will be relatively painless. Although, it looks like some of the tests have broken. I'll have to do some more thorough testing and fix up those tests before I can get a new version out. It should probably take about a week.

In the meantime, I've pushed up a branch (issue-540-serverless-v3). Feel free to try the branch and see if you have any issues with it.

NoxHarmonium added a commit that referenced this issue May 13, 2022
@NoxHarmonium
feat: upgrade to serverless v3 (#540)
0525e3f 
BREAKING CHANGE: serverless v2 is no longer supported. It might still work, but bug fixes/new features will mostly be developed for and tested with serverless v3 (important security/bug fixes _may_ be back ported to v2 versions depending on the uptake of v3)

serverless v3 is now a peer dependency, you will get warnings if you are on earlier versions
@NoxHarmonium NoxHarmonium mentioned this issue May 13, 2022
Merged
NoxHarmonium added a commit that referenced this issue May 13, 2022
@NoxHarmonium
feat: upgrade to serverless v3 (#540)
cf842f0 
BREAKING CHANGE: serverless v2 is no longer supported. It might still work, but bug fixes/new features will mostly be developed for and tested with serverless v3 (important security/bug fixes _may_ be back ported to v2 versions depending on the uptake of v3)

serverless v3 is now a peer dependency, you will get warnings if you are on earlier versions
NoxHarmonium pushed a commit that referenced this issue May 13, 2022
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
d99b0c5 
# [2.0.0](v1.0.1...v2.0.0) (2022-05-13)

### Bug Fixes

* fix case sensitivity issue ([42e9675](42e9675))
* improve the handling of encrypted SQS queues (fixes [#555](#555)) ([789ea78](789ea78))

### Features

* upgrade to serverless v3 ([#540](#540)) ([cf842f0](cf842f0))

### BREAKING CHANGES

* If you have implemented workarounds to allow the lambda to subscribe to an encrypted SQS queue, you may get conflicts as the policy to allow the decryption is now added automatically

- If you provide an key ID, key ARN or reference to a key ARN to the `kmsMasterKeyId` attribute, the relevant 'kms:Decrypt' policy statement should be added automatically to allow the subscription to work correctly
* serverless v2 is no longer supported. It might still work, but bug fixes/new features will mostly be developed for and tested with serverless v3 (important security/bug fixes _may_ be back ported to v2 versions depending on the uptake of v3)

serverless v3 is now a peer dependency, you will get warnings if you are on earlier versions
@NoxHarmonium
Copy link
Collaborator

NoxHarmonium commented May 13, 2022 •
edited

This issue has been resolved in version 2.0.0

The release is available on:

npm package (@latest dist-tag)
GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NoxHarmonium @stefan-rode