prefix parameter not supported #562
Labels
Comments
|
Hi @dnp1, would you be able to provide me with some more information about your issue? Which prefix parameter are you referring to? |
|
Oh I think I've found what you mean, I found that out while working on #313 so when I get a PR up for that, it should also fix this issue. |
NoxHarmonium
added a commit
that referenced
this issue
May 24, 2022
- Although not documented in the readme, there are code paths that allow prefix to be overridden via config. I'm unsure whether this was a feature that was only partially implemented, or maybe an existing feature that was broken at some point, so to be on the safe side, I'll add it to the config schema, but leave it undocumented for now.
NoxHarmonium
added a commit
that referenced
this issue
May 24, 2022
- runServerless is a tool that the serverless team use themselves to test the framework - It allows us to make sure that the plugin in being tested with all the right lifecycle hooks. For example, runServerless will actually validate the provided config against the provided schema, which has already uncovered a bug (#562) - One downside is that we now have build the code as part of running tests, as serverless needs to be able to import the plugin dynamically. However, it seems like this is an acceptable trade off at the moment because building is quite fast (faster than the tests themselves) - Not all the tests run via runServerless yet, but as we go along we should update more tests where appropriate
NoxHarmonium
added a commit
that referenced
this issue
May 24, 2022
- runServerless is a tool that the serverless team use themselves to test the framework - It allows us to make sure that the plugin in being tested with all the right lifecycle hooks. For example, runServerless will actually validate the provided config against the provided schema, which has already uncovered a bug (#562) - One downside is that we now have build the code as part of running tests, as serverless needs to be able to import the plugin dynamically. However, it seems like this is an acceptable trade off at the moment because building is quite fast (faster than the tests themselves) - Not all the tests run via runServerless yet, but as we go along we should update more tests where appropriate
NoxHarmonium
pushed a commit
that referenced
this issue
May 24, 2022
## [2.0.1](v2.0.0...v2.0.1) (2022-05-24) ### Bug Fixes * add 'prefix' to config schema (fixes [#562](#562)) ([4602a63](4602a63))
|
🎉 This issue has been resolved in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: