Improve cmd+enter experience with issues #76

agileseason · Dec 11, 2021 · 4bd12ce · 4bd12ce
1 parent 53346c7
commit 4bd12ce
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/src/components/board/issue_new.vue b/src/components/board/issue_new.vue
@@ -1,7 +1,7 @@
 <template>
   <GlobalEvents
     :filter="(event, handler, eventName) => event.target.tagName !== 'INPUT' && event.target.tagName !== 'TEXTAREA'"
-    @keyup.esc='close'
+    @keydown.esc='close'
   />
   <div class='issue'>
     <div class='issue-header' :style='headerBackgroundColor'>
@@ -22,15 +22,16 @@
           placeholder='Title'
           :disabled='isReadonly'
           ref='title'
-          @keyup.enter='submit'
-          @keyup.esc='close'
+          @keydown.enter='submit'
+          @keydown.esc='close'
         />
 
         <MarkdownEditor
           v-model='body'
           :assignable-users='assignableUsers'
           :disabled='isReadonly'
           class='body'
+          @submit='submit'
         />
 
         <div class='actions'>

diff --git a/src/components/board/issue_show.vue b/src/components/board/issue_show.vue
@@ -2,7 +2,7 @@
   <GlobalEvents
     v-if='isLoaded'
     :filter="(event, handler, eventName) => event.target.tagName !== 'INPUT'"
-    @keyup.esc='close'
+    @keydown.esc='close'
   />
   <div v-if='isNotFound' class='issue'>
     <div class='issue-header'>
@@ -310,7 +310,13 @@ export default {
       'issue/fetchComments',
       'issue/createComment'
     ]),
-    close() { this.$emit('close'); },
+    close() {
+      if (this.isEditBody) {
+        this.isEditBody = false;
+      } else {
+        this.$emit('close');
+      }
+    },
     async fetchIssue() {
       await this.fetch({ id: this.id });
       this.newBody = this.fetchedIssue.body;

diff --git a/src/components/board/issues/title.vue b/src/components/board/issues/title.vue
@@ -10,7 +10,7 @@
     <input
       type='text'
       v-model='newTitle'
-      @keyup.enter='save'
+      @keydown.enter='save'
       @keyup.esc='cancel'
       ref='title'
     />