Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook Integration: resolves #24 #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DanielMiller-agile6
Copy link
Contributor

@DanielMiller-agile6 DanielMiller-agile6 commented Mar 27, 2020

Integrated Storybook so we can experiment and discuss how we might use it for maintenance, design, and development tasks. I only wrote stories for existing reusable components (files under /src/components), along with an additional one to document the site's color palette.

I also removed the package-lock.json file since this isn't used with yarn and can lead to errors for developers and builds. The yarn.lock file has been updated to account for new storybook dependencies.

This PR doesn't change any public-facing site content.

Screen Shot 2020-03-27 at 10 21 26 AM

Resolves #24

@DanielMiller-agile6 DanielMiller-agile6 linked an issue Mar 27, 2020 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Mar 27, 2020

Deploy preview for agile6 ready!

Built with commit 8abb810

https://deploy-preview-27--agile6.netlify.com

@netlify
Copy link

netlify bot commented Mar 27, 2020

Deploy preview for agile6 ready!

Built with commit 0461b91

https://deploy-preview-27--agile6.netlify.com

@ElijahLynn
Copy link
Contributor

Is this something we can route to /storybook?

@DanielMiller-agile6
Copy link
Contributor Author

DanielMiller-agile6 commented Apr 1, 2020

@ElijahLynn That should be possible. You mean as a github-pages site or a route on agile6.com? I still need to work out some scripts for static builds, but it's mostly working i think... I can work on that in a follow up PR. The main gotcha here is how Gatsby compiles static GQL queries separately from storybook build scripts, so in order to publish storybook as a static site, we also need to build the Gatsby site first so that assets from /public are available.

@ElijahLynn
Copy link
Contributor

@ElijahLynn That should be possible. You mean as a github-pages site or a route on agile6.com? I still need to work out some scripts for static builds, but it's mostly working i think... I'll can work on that in a follow up PR. The main gotcha here is how Gatsby compiles static GQL queries separately from storybook build scripts, so in order to publish storybook as a static site, we also need to build the Gatsby site first so that assets from /public are available.

Yeah, I mean as a GJS route. I'll play with this locally soon. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Design System for AgileSix.com
2 participants