fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…

…rgoproj#12395 (argoproj#12784) Signed-off-by: shuangkun <tsk2013uestc@163.com> Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5 · Mar 12, 2024 · 03f9f75 · 03f9f75
1 parent c80b2e9
commit 03f9f75
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx b/ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx
@@ -297,7 +297,8 @@ export function WorkflowLogsViewer({workflow, nodeId, initialPodName, container,
                 )}
                 {execSpec(workflow).podGC && (
                     <>
-                        <WarningIcon /> Your pod GC settings will delete pods and their logs immediately on completion.
+                        <WarningIcon /> Your pod GC settings will delete pods and their logs{' '}
+                        {execSpec(workflow).podGC.deleteDelayDuration ? `after ${execSpec(workflow).podGC.deleteDelayDuration}` : 'immediately'} on completion.
                     </>
                 )}{' '}
                 Logs may not appear for pods that are deleted.{' '}

diff --git a/ui/src/models/workflows.ts b/ui/src/models/workflows.ts
@@ -825,6 +825,7 @@ export interface WorkflowSpec {
      */
     podGC?: {
         strategy?: string;
+        deleteDelayDuration?: string;
     };
     /**
      * SecurityContext holds pod-level security attributes and common container settings.