v0.2.2 -- (hotfix): merge persisted mangas with fetched ones #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- previously fetched mangas would just overwrite the existing mangas
- now that we have important data like chapter read/unread & new
tracking, we can't just overwrite, have to merge them together
- this is a bit of an edge case as the only time there's a conflict is
when a favorited manga also appears in the Latest or Search list
- but it certainly does happen, I just experienced it!
- had chapters overwritten to an empty list bc manga was in Latest
- fixes edge case when persisted favorited manga is overwritten by a fetch of the same manga in latest or search
agilgur5
commented
Nov 23, 2019
agilgur5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously fetched mangas would just overwrite the existing mangas
tracking, we can't just overwrite, have to merge them together
this is a bit of an edge case as the only time there's a conflict is
when a favorited manga also appears in the Latest or Search list
The merge logic here is similar to that used in #23 -- running into similar merging issues in a few places 馃槄 Should really write some tests eventually, at least for the store, with some fake data to test for all these persistence edge cases