Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modal example #48

Open
bpauwels opened this issue Apr 29, 2020 · 1 comment
Open

Add a modal example #48

bpauwels opened this issue Apr 29, 2020 · 1 comment
Labels
problem: stale Issue author has not responded scope: example An example or examples could be improved solution: duplicate

Comments

@bpauwels
Copy link

Hi there,

I'm sorry if there was an abusive comment here #44 but after a few days working on a project with react-signature-canvas I have to say that this example by far helped me the most.

Especially the whole useRef({}) thing was hard to figure out, and tbh by now I did not really get why I need to provide a runction for the ref property (measuredref in the example)

Took me quite a while to find this - so probably reconsider adding it to the docs?!

Cheers,
Benedikt

@agilgur5
Copy link
Owner

agilgur5 commented May 3, 2020

I never said I wouldn't consider adding a modal example, both #44 and #46 are even tagged as "example" and I even said in #46 (comment) that this "could be good for a Storybook with progressively advanced use cases in the future".
Neither claimed to be a modal example, however, both claimed to be hooks examples. In fact, I specifically changed the names of those to better reflect what they're about and make them more easily searchable/found. And neither was a PR. Nor a very guided, walk-through tutorial like the blog post I linked to.

I've currently been spending my limited free time maintaining TSDX, so I haven't had time to focus on this unfortunately. TSDX requires a lot of attention for better or for worse, this library is re-written with in #42, and it has some support for Storybook too. It has increased my productivity in several libraries (as well as many other authors'), but also has taken my time and attention away unfortunately.


Also it wasn't just "an abusive comment", the OP there repeatedly harassed me over email too for god knows what malicious reason, so suffice to say, that's not some heartwarming thanks I'd like to be reminded of. That is also not a hypothetical "if", it 100% factually happened -- please do not add gaslighting (another form of abuse) to the mix.

@agilgur5 agilgur5 added solution: duplicate scope: example An example or examples could be improved labels May 3, 2020
@agilgur5 agilgur5 changed the title Reconsider adding modal example to the docs Add a modal example May 3, 2020
@agilgur5 agilgur5 added the problem: stale Issue author has not responded label Mar 13, 2021
@agilgur5 agilgur5 added this to the Storybook with examples milestone Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem: stale Issue author has not responded scope: example An example or examples could be improved solution: duplicate
Projects
None yet
Development

No branches or pull requests

2 participants