Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type error message changed to data-parsley-type-message in parsley 2.x #56

Closed
blue-o opened this issue Apr 29, 2015 · 4 comments
Closed
Assignees

Comments

@blue-o
Copy link

blue-o commented Apr 29, 2015

I have noticed the change made in parsley 2.x in regard to type errors from data-parsley-'specific type'-message to the general type error message, data-parsley-type-message, but there is no adjustment in django-parsley. I wonder when this will be reflected.

Cheers.

@shivakrshn49
Copy link

@blue-o Can you share a link that you noticed the change ?

@blue-o
Copy link
Author

blue-o commented May 4, 2015

I haven't got it with me just now, but If you test it with
data-parsley-email-message in html, you will be able to see the error
message is not showing up. If you change that to
data-parsley-error-message, the general error message, you'll be seeing it.

I hope this will help.

On Wed, Apr 29, 2015 at 5:10 PM, Shiva Krishna notifications@github.com
wrote:

@blue-o https://github.com/blue-o Can you share a link that you noticed
the change ?


Reply to this email directly or view it on GitHub
#56 (comment)
.

@akshar-raaj akshar-raaj self-assigned this Sep 1, 2015
@akshar-raaj
Copy link
Member

Parsley.js 1.x behaviour:

<input type="text" name="number" parsley-type="number" parsley-type-number-message="Missing Number"/>

In parsley.js 2.x, the equivalent of above would be

<input type="text" name="number" data-parsley-type="number" data-parsley-type-message="Missing Number"/>

So parsley-type-number-message changed to data-parsley-type-message.

I assume this is what @blue-o wants reflected in Django-parsley.

@akshar-raaj
Copy link
Member

@blue-o The change you asked for has been implemented here

863e3f4

It's merged to master now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants