Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsley 1.2 support #29

Merged
merged 11 commits into from Nov 28, 2013
Merged

Parsley 1.2 support #29

merged 11 commits into from Nov 28, 2013

Conversation

tuxcanfly
Copy link
Member

They've dropped the data- syntax and moved to parsley-

Maybe need to include some docs around this and a switch between <1.2 or >1.2.

@chachra
Copy link

chachra commented Nov 22, 2013

agreed, not working as expected.

chachra pushed a commit to Tivix/Django-parsley that referenced this pull request Nov 22, 2013
@treyhunner
Copy link
Contributor

I don't think the attribute prefix should be hard coded because the prefix can be changed with the data-parsley-namespace form attribute or the namespace parsley option.

Maybe there should be a namespace meta option of an optional namespace keyword given to the decorator?

@tuxcanfly
Copy link
Member

Good idea... on it.

@tuxcanfly
Copy link
Member

Done. Meta attr parsley_namespace now provides the prefix which defaults to parsley and next version will ship with parsleyjs 1.2. What about people not using the app staticfiles? They'll face an issue when django-parsley > 0.2 but parsleyjs < 1.2...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 4beca9a on parsley-1.2 into 1438f31 on master.

@tuxcanfly
Copy link
Member

I think we can put down a note in the docs on how to work with parsleyjs < 1.2.. specifically to set parsley_namepsace = data

@shabda
Copy link
Member

shabda commented Nov 28, 2013

@tuxcanfly : Shouldn we default parsley_namepsace = data if not set to maintain backwards compatibility? (And update docs too),

@tuxcanfly
Copy link
Member

@shabda parsleyjs itself is not backward compatible so I guess it can't be helped.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) when pulling 502208c on parsley-1.2 into 1438f31 on master.

tuxcanfly added a commit that referenced this pull request Nov 28, 2013
@tuxcanfly tuxcanfly merged commit 2cb60c3 into master Nov 28, 2013
@tuxcanfly tuxcanfly deleted the parsley-1.2 branch November 28, 2013 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants