Class based blogango #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d view and added LoginRequiredMixin mixin as decorators
…d view and added StaffMemReqMixin replacing @staff_member_required method decorator
…ew and placed two CBVs for admin entry and admin edit
get() is the starting point of View. Any check before view execution should happen here. get_queryset() should be exclusively used for creating and getting the entries.
…xin from install_blog url and converted installblog view to template view
…ngo into class_based_blogango
…ngo into class_based_blogango
… render 404 instead of last page for invalid pagination
…edirects to 404 if invalid url instead of last page. Modified related test case
…red,include as they were unused in urls.py
…user if not signed in
we aren't concerned with only showing the list of Drafts. We want to show several lists here. So better choice would be TemplateView with all the context vars calculated in get_context_data.
…ents per page fetches from settings file instead of paginate_by
…lements autocomplete on tags field previously adminentryview was not implementing the same
…th author as current user and publish date with current datetime
…ssage after saving a blog entry
…o get success url
…quest.user now it checks for kwargs
…View(for editing a blog entry) Blog create page and edit page has a lot in common. Keep the common code in a superclass and let these two views extend from that class.
Reuse code in AdminEntryView(for creating a blog entry) and AdminEditVie...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.